svn commit: r240993 - head/sys/cam/ctl

Alexey Dokuchaev danfe at FreeBSD.org
Thu Sep 27 13:18:10 UTC 2012


On Thu, Sep 27, 2012 at 10:51:38AM +0000, Edward Tomasz Napierala wrote:
> New Revision: 240993
> URL: http://svn.freebsd.org/changeset/base/240993
> 
> Log:
>   Remove useless NULL checks after M_WAITOK allocations.
> 
> @@ -1520,12 +1520,6 @@ ctl_ioctl_do_datamove(struct ctl_scsiio 
>  
>  	ext_sglist = (struct ctl_sg_entry *)malloc(ext_sglen, M_CTL, M_WAITOK);

You could have also removed bogus casting of void * returned by malloc().
Perhaps it makes sense to clean up more than just this file thought.

./danfe


More information about the svn-src-all mailing list