svn commit: r240549 - head/sys/arm/tegra

Eitan Adler eadler at freebsd.org
Sun Sep 16 18:38:05 UTC 2012


On 16 September 2012 13:45, Chris Rees <utisoft at gmail.com> wrote:
> On 16 September 2012 18:41, Ian Lepore <freebsd at damnhippie.dyndns.org> wrote:
>> On Sun, 2012-09-16 at 18:30 +0100, Chris Rees wrote:
>>> On 16 Sep 2012 16:19, "David Chisnall" <theraven at freebsd.org> wrote:
>>> >
>>> > On 16 Sep 2012, at 10:37, Chris Rees wrote:
>>> >
>>> > > Actually:
>>> > >
>>> > > for (;;)
>>> > >        ;
>>> >
>>> > This form will generate a compiler warning, because it looks like a
>>> missing loop body.  You can silence the warning by this form:
>>> >
>>> > for (;;) {}
>>> >
>>> > This makes it clear that you have an explicit body containing no
>>> statements.
>>>
>>> Please fix the style man page then, and make sure bde approves!
>>
>> One of the examples allows
>>
>>     for (;;)
>>         stmt;
>>
>> Using "continue;" as the statement is consistant with that.
>
> Ok, so with approval from a docs/src guy I'd like to commit [1] to
> update the style page to use continue; instead of a lone ;
>
> Anyone like to approve/commit?

+1 to your patch, though I prefer "do nothing" to "nothing."

>
> Chris
>
> [1] http://www.bayofrum.net/~crees/patches/style-empty-loop.diff
>



-- 
Eitan Adler
Source & Ports committer
X11, Bugbusting teams


More information about the svn-src-all mailing list