svn commit: r240484 - head/sys/dev/fdt

[Aleksandr Rybalko]

On Fri, 14 Sep 2012 18:41:13 +0200
Grzegorz Bernacki <gber at freebsd.org> wrote:

> On 09/14/12 16:16, Aleksandr Rybalko wrote:
> > On Fri, 14 Sep 2012 09:33:35 +0000 (UTC)
> > Grzegorz Bernacki<gber at FreeBSD.org>  wrote:
> >
> >> Author: gber
> >> Date: Fri Sep 14 09:33:35 2012
> >> New Revision: 240484
> >> URL: http://svn.freebsd.org/changeset/base/240484
> >>
> >> Log:
> >>    Set busaddr and bussize to 0 when fdt_get_range() fails.
> >
> > Why bussize is 0?
> 
> I though that setting it to 0 makes sense, since we do not use
> this variable in this function and setting it to some value could be 
> confused. I could skip setting it, but I also thought it could cause 
> confusion :). If you think that setting it to other value or remove
> it will be better please let me know and I will change it.
> 
> thanks
> grzesiek

Yeah, indeed, false alarm. Sorry for noise.

But it will be very nice to hear developers opinion about ePAPR1.1 row
(about "range" property):
"If the property is not present in a bus node, it is assumed that no
mapping exists between children of the node and the parent address
space."

Assuming since in most cases root node have no "ranges" property, but
his child "SOC" have that property with defaults (0x0 x 0xffffffff).
So nodes which have property "ranges" or not, must be processed same
way. Right?

WBW
-- 
Aleksandr Rybalko <ray at freebsd.org>