svn commit: r240225 - stable/9/sys/cddl/compat/opensolaris/sys

Doug Barton dougb at FreeBSD.org
Mon Sep 10 00:26:19 UTC 2012


On 9/8/2012 12:39 PM, Eitan Adler wrote:
> On 8 September 2012 15:36, Doug Barton <dougb at freebsd.org> wrote:
>> On 09/08/2012 12:21, Martin Matuska wrote:
>>> This commit is missing the PR number
>>
>> It's actually pretty common to summarize the commit message in an MFC,
>> rather than reproducing it verbatim.
> 
> The PR number is still important in order for dfilter to act
> correctly. 

While reasonable minds can differ on this topic, I regard that as a
reason _not_ to include the PR number in merges. IMO it's far better to
have one line "MFCs complete" than it is to repeat the same commit
message verbatim in GNATS N times.

Doug

-- 

    I am only one, but I am one.  I cannot do everything, but I can do
    something.  And I will not let what I cannot do interfere with what
    I can do.
			-- Edward Everett Hale, (1822 - 1909)


More information about the svn-src-all mailing list