svn commit: r240165 - head/usr.sbin/pc-sysinstall/backend

Jos Backus jos at catnook.com
Thu Sep 6 21:50:27 UTC 2012


On Thu, Sep 6, 2012 at 7:59 AM, Josh Paetzel <jpaetzel at freebsd.org> wrote:

> Modified: head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh
>
> ==============================================================================
> --- head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh   Thu Sep  6
> 13:54:01 2012        (r240164)
> +++ head/usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh   Thu Sep  6
> 14:59:53 2012        (r240165)
> ...
>    FOUNDPARTS="1"
> +  USEDAUTOSIZE=0
>
>    # Lets read in the config file now and setup our partitions
>    if [ "${_pType}" = "gpt" ] ; then
> @@ -245,7 +278,15 @@ setup_gpart_partitions()
>
>        if [ "$SIZE" = "0" ]
>        then
> -        SOUT=""
> +       if [ $USEDAUTOSIZE -eq 1 ] ; then
>

Style question: if $USEDAUTOSIZE is treated as a boolean value, why not use
`true' and `false' instead of `1' and `0'? No need to make shell code look
like C code. That way one can write:

if $USEDAUTOSIZE; then

Jos
-- 
Jos Backus
jos at catnook.com


More information about the svn-src-all mailing list