svn commit: r240067 - head/sys/kern

[Aleksandr Rybalko]

On Mon, 3 Sep 2012 02:05:15 -0700
Garrett Cooper <yanegomi at gmail.com> wrote:

>> On Sep 3, 2012, at 1:52 AM, Aleksandr Rybalko wrote:
>> 
>> > Author: ray
>> > Date: Mon Sep  3 08:52:05 2012
>> > New Revision: 240067
>> > URL: http://svn.freebsd.org/changeset/base/240067
>> > 
>> > Log:
>> >  Add kern.hintmode sysctl variable to show current state of hints:
>> >  0 - loader hints in environment only;
>> >  1 - static hints only
>> >  2 - fallback mode (Dynamic KENV with fallback to kernel
>> > environment) Add kern.hintmode write handler, accept only value 2.
>> > That will switch static KENV to dynamic. So it will be possible to
>> > change device hints.
>> 
>> ...
>> 
>> > +	/* Migrate from static to dynamic hints */
>> > +	switch (hintmode) {
>> > +	case 0:
>> > +		if (dynamic_kenv)
>> > +			/* Already here */
>> > +			hintmode = value; /* XXX: Need we switch
>> > or not ? */
>> > +			return (0);
>> 
>> ^^^^ typo (missing braces)? ^^^^

Fixed.

>> 
>> Also, don't you need extra glue for jails?
>> 
>> -Garrett

Thanks Garrett!

WBW
-- 
Aleksandr Rybalko <ray at freebsd.org>