svn commit: r242161 - in head/sys: net netinet netpfil/pf

[Andre Oppermann]

On 28.10.2012 00:01, Gleb Smirnoff wrote:
> On Sat, Oct 27, 2012 at 12:58:52PM +0200, Andre Oppermann wrote:
> A> On 26.10.2012 23:06, Gleb Smirnoff wrote:
> A> > Author: glebius
> A> > Date: Fri Oct 26 21:06:33 2012
> A> > New Revision: 242161
> A> > URL: http://svn.freebsd.org/changeset/base/242161
> A> >
> A> > Log:
> A> >    o Remove last argument to ip_fragment(), and obtain all needed information
> A> >      on checksums directly from mbuf flags. This simplifies code.
> A> >    o Clear CSUM_IP from the mbuf in ip_fragment() if we did checksums in
> A> >      hardware. Some driver may not announce CSUM_IP in theur if_hwassist,
> A> >      although try to do checksums if CSUM_IP set on mbuf. Example is em(4).
> A>
> A> I'm not getting your description here?  Why work around a bug in a driver
> A> in ip_fragment() when we can fix the bug in the driver?
>
> Well, that was actually bug in the stack and a very special driver that
> demonstrates it. I may even agree that driver is incorrect, but the stack was
> incorrect, too.

Ah, OK.  Do you intend to fix the driver as well?

-- 
Andre