svn commit: r242254 - head/sys/netinet

Andre Oppermann andre at freebsd.org
Sun Oct 28 21:03:40 UTC 2012


On 28.10.2012 21:07, Gleb Smirnoff wrote:
> On Sun, Oct 28, 2012 at 06:07:34PM +0000, Andre Oppermann wrote:
> A> @@ -296,8 +297,8 @@ syncache_destroy(void)
> A>  		mtx_destroy(&sch->sch_mtx);
> A>  	}
> A>
> A> -	KASSERT(V_tcp_syncache.cache_count == 0, ("%s: cache_count %d not 0",
> A> -	    __func__, V_tcp_syncache.cache_count));
> A> +	KASSERT(uma_zone_get_cur(V_tcp_syncache.zone) == 0,
> A> +	    ("%s: cache_count not 0", __func__));
> A>
> A>  	/* Free the allocated global resources. */
> A>  	uma_zdestroy(V_tcp_syncache.zone);
>
> btw, keg_dtor() which is called in uma_zdestroy() printfs a warning
> (even on non-invariant kernel) if keg had items in it. So leak won't
> be unnoticed.

Thanks, didn't know that.  I leave the KASSERT() in if you don't
mind to make it a bit more forceful than a printf that gets overlooked
too easily.

-- 
Andre



More information about the svn-src-all mailing list