svn commit: r242120 - head/usr.sbin/cpucontrol

[Dimitry Andric]

On 2012-10-26 15:37, Jan Beich wrote:
> Eitan Adler <eadler at FreeBSD.org> writes:
>
>> Author: eadler
>> Date: Fri Oct 26 02:50:16 2012
>> New Revision: 242120
>> URL: http://svn.freebsd.org/changeset/base/242120
>>
>> Log:
>>    This utility builds without NO_WCAST_ALIGN
>
> Not for clang. It probably predates NO_WCAST_ALIGN.clang= support.
>
> intel.c:66:3: warning: cast from 'char *' to 'uint32_t *' (aka 'unsigned int *')
>        increases required alignment from 1 to 4 [-Wcast-align]
>          ((uint32_t *)vendor)[0] = idargs.data[1];
>           ^~~~~~~~~~~~~~~~~~

Yes, on x86, you can safely turn off the -Wcast-align warnings, if it is
easier.  It is probably not worth the trouble to go through the code and
fix the alignment issues, if it will never be run on alignment-sensitive
architectures.