svn commit: r243627 - head/sys/kern

Robert N. M. Watson rwatson at FreeBSD.org
Tue Nov 27 23:05:42 UTC 2012


On 27 Nov 2012, at 22:54, Andre Oppermann wrote:

>>>> Andre.. this breaks incoming connections.  TCP is immediately reset and never even gets to the
>>>> listener process.  You need to back out of fix this urgently please.
>>> 
>>> I just found out and fixed it.  Sorry for the breakage.
>> 
>> I'd like to see a much more thorough use of "Reviewed by:" in socket and TCP-related commits -- this
>> is very sensitive code, and a second pair of eyes is always valuable.  Post-commit review is not a
>> substitute.  Looking back over similar changes in the socket code over the last two years, I see
>> that almost all have reviewers, so I think it would be reasonable to consider it mandatory for these
>> subsystems at this point.  The good news is that we have lots of people with expertise in it.
> 
> Good to see you becoming more active again. :-)  And yes,
> you have a point there.

Yes -- this is only about three weeks old, however; for the prior six-twelve months, I've been fairly non-existent in FreeBSD-land due to outside obligations :-).

Robert


More information about the svn-src-all mailing list