svn commit: r243142 - in head/sys: fs/nfsclient kern sys

[Pawel Jakub Dawidek]

On Sun, Nov 25, 2012 at 06:21:52PM +0200, Konstantin Belousov wrote:
> On Sat, Nov 24, 2012 at 11:24:08PM +0100, Pawel Jakub Dawidek wrote:
> > I think we should move zpfind_locked() under 'pid <= PID_MAX':
> > 
> > 	sx_slock(&allproc_lock);
> > 	if (pid <= PID_MAX) {
> > 		p = pfind_locked(pid);
> > 		if (p == NULL && (flags & PGET_NOTWEXIT) == 0)
> > 			p = zpfind_locked(pid);
> > 	} else if ((flags & PGET_NOTID) == 0) {
> > 		p = pfind_tid_locked(pid);
> > 	} else {
> > 		p = NULL;
> > 	}
> > 	sx_sunlock(&allproc_lock);
> > 	if (p == NULL)
> > 		return (ESRCH);
> > 
> 
> Yes, I agree. Please remove {} for one-line blocks.

If I need braces in one place, I put them into all the places so that
all the elses are aligned. style(9) does allow that.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20121125/df55e927/attachment.sig>