svn commit: r243474 - head/usr.bin/cut
Dimitry Andric
dim at FreeBSD.org
Sat Nov 24 14:11:57 UTC 2012
On 2012-11-24 09:00, Andrey Chernov wrote:
> On 24.11.2012 8:15, Andrew Turner wrote:
>> The is_delim function works on wchar_t characters not ints, update the
>> function to take a wchar_t as it's argument.
>> static int
>> -is_delim(int ch)
>> +is_delim(wchar_t ch)
>> {
>> if (wflag) {
>> if (ch == ' ' || ch == '\t')
>>
>
> I can't look at the whole code at this moment, but taking standalone
> this is incorrect comparison for wchar_t. Should be L' ' and L'\t' instead.
The compiler just promotes the space and tab to wchar_t, this is only
needed for the sake of consistency (and/or style). There is no binary
change if you add the L prefixes. :)
More information about the svn-src-all
mailing list