svn commit: r235941 - in head/sys: amd64/include arm/include i386/include ia64/include mips/include powerpc/include sparc64/include

Bjoern A. Zeeb bz at FreeBSD.org
Thu May 24 22:00:49 UTC 2012


Author: bz
Date: Thu May 24 22:00:48 2012
New Revision: 235941
URL: http://svn.freebsd.org/changeset/base/235941

Log:
  MFp4 bz_ipv6_fast:
  
    in_cksum.h required ip.h to be included for struct ip.  To be
    able to use some general checksum functions like in_addword()
    in a non-IPv4 context, limit the (also exported to user space)
    IPv4 specific functions to the times, when the ip.h header is
    present and IPVERSION is defined (to 4).
  
    We should consider more general checksum (updating) functions
    to also allow easier incremental checksum updates in the L3/4
    stack and firewalls, as well as ponder further requirements by
    certain NIC drivers needing slightly different pseudo values
    in offloading cases.  Thinking in terms of a better "library".
  
    Sponsored by:	The FreeBSD Foundation
    Sponsored by:	iXsystems
  
  Reviewed by:	gnn (as part of the whole)
  MFC After:	3 days

Modified:
  head/sys/amd64/include/in_cksum.h
  head/sys/arm/include/in_cksum.h
  head/sys/i386/include/in_cksum.h
  head/sys/ia64/include/in_cksum.h
  head/sys/mips/include/in_cksum.h
  head/sys/powerpc/include/in_cksum.h
  head/sys/sparc64/include/in_cksum.h

Modified: head/sys/amd64/include/in_cksum.h
==============================================================================
--- head/sys/amd64/include/in_cksum.h	Thu May 24 21:55:36 2012	(r235940)
+++ head/sys/amd64/include/in_cksum.h	Thu May 24 22:00:48 2012	(r235941)
@@ -43,6 +43,7 @@
 
 #define in_cksum(m, len)	in_cksum_skip(m, len, 0)
 
+#if defined(IPVERSION) && (IPVERSION == 4)
 /*
  * It it useful to have an Internet checksum routine which is inlineable
  * and optimized specifically for the task of computing IP header checksums
@@ -69,9 +70,12 @@ in_cksum_update(struct ip *ip)
 	} while(0)
 
 #endif
+#endif
 
 #ifdef _KERNEL
+#if defined(IPVERSION) && (IPVERSION == 4)
 u_int in_cksum_hdr(const struct ip *ip);
+#endif
 u_short	in_addword(u_short sum, u_short b);
 u_short	in_pseudo(u_int sum, u_int b, u_int c);
 u_short	in_cksum_skip(struct mbuf *m, int len, int skip);

Modified: head/sys/arm/include/in_cksum.h
==============================================================================
--- head/sys/arm/include/in_cksum.h	Thu May 24 21:55:36 2012	(r235940)
+++ head/sys/arm/include/in_cksum.h	Thu May 24 22:00:48 2012	(r235941)
@@ -46,7 +46,9 @@ u_short in_cksum(struct mbuf *m, int len
 u_short in_addword(u_short sum, u_short b);
 u_short in_cksum_skip(struct mbuf *m, int len, int skip);
 u_int do_cksum(const void *, int);
+#if defined(IPVERSION) && (IPVERSION == 4)
 u_int in_cksum_hdr(const struct ip *);
+#endif
 
 static __inline u_short
 in_pseudo(u_int sum, u_int b, u_int c)

Modified: head/sys/i386/include/in_cksum.h
==============================================================================
--- head/sys/i386/include/in_cksum.h	Thu May 24 21:55:36 2012	(r235940)
+++ head/sys/i386/include/in_cksum.h	Thu May 24 22:00:48 2012	(r235941)
@@ -54,6 +54,7 @@
  * therefore always exactly five 32-bit words.
  */
 #if defined(__GNUCLIKE_ASM) && !defined(__INTEL_COMPILER)
+#if defined(IPVERSION) && (IPVERSION == 4)
 static __inline u_int
 in_cksum_hdr(const struct ip *ip)
 {
@@ -88,6 +89,7 @@ in_cksum_update(struct ip *ip)
 	__tmpsum = (int)ntohs(ip->ip_sum) + 256;
 	ip->ip_sum = htons(__tmpsum + (__tmpsum >> 16));
 }
+#endif
 
 static __inline u_short
 in_addword(u_short sum, u_short b)
@@ -121,6 +123,7 @@ in_pseudo(u_int sum, u_int b, u_int c)
 }
 
 #else
+#if defined(IPVERSION) && (IPVERSION == 4)
 #define	in_cksum_update(ip) \
 	do { \
 		int __tmpsum; \
@@ -129,10 +132,13 @@ in_pseudo(u_int sum, u_int b, u_int c)
 	} while(0)
 
 #endif
+#endif
 
 #ifdef _KERNEL
 #if !defined(__GNUCLIKE_ASM) || defined(__INTEL_COMPILER)
+#if defined(IPVERSION) && (IPVERSION == 4)
 u_int in_cksum_hdr(const struct ip *ip);
+#endif
 u_short in_addword(u_short sum, u_short b);
 u_short in_pseudo(u_int sum, u_int b, u_int c);
 #endif

Modified: head/sys/ia64/include/in_cksum.h
==============================================================================
--- head/sys/ia64/include/in_cksum.h	Thu May 24 21:55:36 2012	(r235940)
+++ head/sys/ia64/include/in_cksum.h	Thu May 24 22:00:48 2012	(r235941)
@@ -39,6 +39,7 @@
 
 #define in_cksum(m, len)	in_cksum_skip(m, len, 0)
 
+#if defined(IPVERSION) && (IPVERSION == 4)
 /*
  * It it useful to have an Internet checksum routine which is inlineable
  * and optimized specifically for the task of computing IP header checksums
@@ -65,9 +66,12 @@ in_cksum_update(struct ip *ip)
 	} while(0)
 
 #endif
+#endif
 
 #ifdef _KERNEL
+#if defined(IPVERSION) && (IPVERSION == 4)
 u_int in_cksum_hdr(const struct ip *ip);
+#endif
 u_short	in_addword(u_short sum, u_short b);
 u_short	in_pseudo(u_int sum, u_int b, u_int c);
 u_short	in_cksum_skip(struct mbuf *m, int len, int skip);

Modified: head/sys/mips/include/in_cksum.h
==============================================================================
--- head/sys/mips/include/in_cksum.h	Thu May 24 21:55:36 2012	(r235940)
+++ head/sys/mips/include/in_cksum.h	Thu May 24 22:00:48 2012	(r235941)
@@ -40,6 +40,7 @@
 
 #define	in_cksum(m, len)	in_cksum_skip(m, len, 0)
 
+#if defined(IPVERSION) && (IPVERSION == 4)
 /*
  * It it useful to have an Internet checksum routine which is inlineable
  * and optimized specifically for the task of computing IP header checksums
@@ -66,9 +67,12 @@ in_cksum_update(struct ip *ip)
 	} while(0)
 
 #endif
+#endif
 
 #ifdef _KERNEL
+#if defined(IPVERSION) && (IPVERSION == 4)
 u_int in_cksum_hdr(const struct ip *ip);
+#endif
 u_short in_addword(u_short sum, u_short b);
 u_short in_pseudo(u_int sum, u_int b, u_int c);
 u_short in_cksum_skip(struct mbuf *m, int len, int skip);

Modified: head/sys/powerpc/include/in_cksum.h
==============================================================================
--- head/sys/powerpc/include/in_cksum.h	Thu May 24 21:55:36 2012	(r235940)
+++ head/sys/powerpc/include/in_cksum.h	Thu May 24 22:00:48 2012	(r235941)
@@ -39,6 +39,7 @@
 
 #define in_cksum(m, len)	in_cksum_skip(m, len, 0)
 
+#if defined(IPVERSION) && (IPVERSION == 4)
 /*
  * It it useful to have an Internet checksum routine which is inlineable
  * and optimized specifically for the task of computing IP header checksums
@@ -65,9 +66,12 @@ in_cksum_update(struct ip *ip)
 	} while(0)
 
 #endif
+#endif
 
 #ifdef _KERNEL
+#if defined(IPVERSION) && (IPVERSION == 4)
 u_int in_cksum_hdr(const struct ip *ip);
+#endif
 u_short	in_addword(u_short sum, u_short b);
 u_short	in_pseudo(u_int sum, u_int b, u_int c);
 u_short	in_cksum_skip(struct mbuf *m, int len, int skip);

Modified: head/sys/sparc64/include/in_cksum.h
==============================================================================
--- head/sys/sparc64/include/in_cksum.h	Thu May 24 21:55:36 2012	(r235940)
+++ head/sys/sparc64/include/in_cksum.h	Thu May 24 22:00:48 2012	(r235941)
@@ -65,6 +65,7 @@
 
 #define	in_cksum(m, len)	in_cksum_skip(m, len, 0)
 
+#if defined(IPVERSION) && (IPVERSION == 4)
 static __inline void
 in_cksum_update(struct ip *ip)
 {
@@ -73,6 +74,7 @@ in_cksum_update(struct ip *ip)
 	__tmp = (int)ip->ip_sum + 1;
 	ip->ip_sum = __tmp + (__tmp >> 16);
 }
+#endif
 
 static __inline u_short
 in_addword(u_short sum, u_short b)
@@ -106,6 +108,7 @@ in_pseudo(u_int sum, u_int b, u_int c)
 	return (sum);
 }
 
+#if defined(IPVERSION) && (IPVERSION == 4)
 static __inline u_int
 in_cksum_hdr(struct ip *ip)
 {
@@ -163,6 +166,7 @@ in_cksum_hdr(struct ip *ip)
 #undef __LD_ADD
 	return (__ret);
 }
+#endif
 
 #ifdef _KERNEL
 u_short	in_cksum_skip(struct mbuf *m, int len, int skip);


More information about the svn-src-all mailing list