svn commit: r235129 - head/tools/tools/zfsboottest

[Andriy Gapon]

on 08/05/2012 05:01 Pawel Jakub Dawidek said the following:
> On Mon, May 07, 2012 at 03:03:42PM +0000, Andriy Gapon wrote:
>> Author: avg
>> Date: Mon May  7 15:03:42 2012
>> New Revision: 235129
>> URL: http://svn.freebsd.org/changeset/base/235129
>>
>> Log:
>>   zfsboottest.sh: gracefully handle default value of bootfs property
> 
> I'd prefer if people avoid having their root file system at the pool
> level, so maybe we could leave it as a warning?

I see reasons to have this preference, I am just not sure that _this_ tool
should be used to annoy people by telling them that their preference is inferior.
I think that the various ZFS setup guides and howtos (including those by you)
should already provide good examples.  So if somebody doesn't follow them to the
letter, then he is probably confident of his ZFS mastery.

>>   Reported by:	theraven
>>   MFC after:	10 days
>>
>> Modified:
>>   head/tools/tools/zfsboottest/zfsboottest.sh
>>
>> Modified: head/tools/tools/zfsboottest/zfsboottest.sh
>> ==============================================================================
>> --- head/tools/tools/zfsboottest/zfsboottest.sh	Mon May  7 14:07:13 2012	(r235128)
>> +++ head/tools/tools/zfsboottest/zfsboottest.sh	Mon May  7 15:03:42 2012	(r235129)
>> @@ -52,8 +52,7 @@ if [ $? -ne 0 ]; then
>>  fi
>>  bootfs=`zpool get bootfs "${pool}" | tail -1 | awk '{print $3}'`
>>  if [ "${bootfs}" = "-" ]; then
>> -	echo "The \"bootfs\" property is not configured for pool \"${pool}\"." >&2
>> -	exit 1
>> +	bootfs="${pool}"
>>  fi
>>  # Dataset's mountpoint property should be set to 'legacy'.
>>  if [ "`zfs get -H -o value mountpoint ${bootfs}`" != "legacy" ]; then
> 


-- 
Andriy Gapon