svn commit: r233052 - head/share/mk

Mark Linimon linimon at lonesome.com
Wed Mar 21 00:48:37 UTC 2012


The style in bsd.port.mk is not consistent.  (I know, this is shocking
for something that's at r1.706.)

Here's what I recall seeing in it, that I found readable:

.if defined(USE_GL)
. if ${USE_GL:L} == "yes"
USE_GL=     glu
. endif
. for _component in ${USE_GL}
.  if !defined(_GL_${_component}_LIB_DEPENDS) && \
        !defined(_GL_${_component}_RUN_DEPENDS)
IGNORE=     uses unknown GL component
.  else
LIB_DEPENDS+=   ${_GL_${_component}_LIB_DEPENDS}
RUN_DEPENDS+=   ${_GL_${_component}_RUN_DEPENDS}
.  endif
. endfor
.endif

Various other bits of ports/Mk/*.mk use this same indentation; others
use two spaces, tabs, ...

Unfortunately the counter-argument of "let's just go fix it to have one
style" is all the patches against bsd.port.mk that would then no longer
apply.

Personally, I'd like to see us pick a "recommended way for new code",
whether it's one or two spaces, whatever.  (8 spaces seems too much.)

mcl


More information about the svn-src-all mailing list