svn commit: r232882 - in head/sys/dev: advansys aic7xxx buslogic dpt iir

Juli Mallett jmallett at FreeBSD.org
Mon Mar 12 19:29:33 UTC 2012


Author: jmallett
Date: Mon Mar 12 19:29:32 2012
New Revision: 232882
URL: http://svn.freebsd.org/changeset/base/232882

Log:
  Remove comments about creating DMA tags as children of the DMA tags of their
  parent bus where the code has now been modified to do so.
  
  Reviewed by:	scottl

Modified:
  head/sys/dev/advansys/adv_pci.c
  head/sys/dev/advansys/adw_pci.c
  head/sys/dev/aic7xxx/ahc_eisa.c
  head/sys/dev/aic7xxx/ahc_isa.c
  head/sys/dev/aic7xxx/ahc_pci.c
  head/sys/dev/aic7xxx/ahd_pci.c
  head/sys/dev/buslogic/bt_pci.c
  head/sys/dev/dpt/dpt_pci.c
  head/sys/dev/iir/iir_pci.c

Modified: head/sys/dev/advansys/adv_pci.c
==============================================================================
--- head/sys/dev/advansys/adv_pci.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/advansys/adv_pci.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -187,7 +187,6 @@ adv_pci_attach(device_t dev)
 	}
 
 	/* Allocate a dmatag for our transfer DMA maps */
-	/* XXX Should be a child of the PCI bus dma tag */
 	error = bus_dma_tag_create(
 			/* parent	*/ bus_get_dma_tag(dev),
 			/* alignment	*/ 1,

Modified: head/sys/dev/advansys/adw_pci.c
==============================================================================
--- head/sys/dev/advansys/adw_pci.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/advansys/adw_pci.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -258,7 +258,6 @@ adw_pci_attach(device_t dev)
 	pci_write_config(dev, PCIR_COMMAND, command, /*bytes*/1);
 
 	/* Allocate a dmatag for our transfer DMA maps */
-	/* XXX Should be a child of the PCI bus dma tag */
 	error = bus_dma_tag_create(
 			/* parent	*/ bus_get_dma_tag(dev),
 			/* alignment	*/ 1,

Modified: head/sys/dev/aic7xxx/ahc_eisa.c
==============================================================================
--- head/sys/dev/aic7xxx/ahc_eisa.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/aic7xxx/ahc_eisa.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -130,7 +130,6 @@ aic7770_attach(device_t dev)
 	ahc_set_unit(ahc, device_get_unit(dev));
 
 	/* Allocate a dmatag for our SCB DMA maps */
-	/* XXX Should be a child of the PCI bus dma tag */
 	error = aic_dma_tag_create(ahc, /*parent*/bus_get_dma_tag(dev),
 				   /*alignment*/1, /*boundary*/0,
 				   /*lowaddr*/BUS_SPACE_MAXADDR_32BIT,

Modified: head/sys/dev/aic7xxx/ahc_isa.c
==============================================================================
--- head/sys/dev/aic7xxx/ahc_isa.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/aic7xxx/ahc_isa.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -253,7 +253,6 @@ ahc_isa_attach(device_t dev)
 	ahc_set_unit(ahc, device_get_unit(dev));
 
 	/* Allocate a dmatag for our SCB DMA maps */
-	/* XXX Should be a child of the VLB/ISA bus dma tag */
 	error = aic_dma_tag_create(ahc, /*parent*/bus_get_dma_tag(dev),
 				   /*alignment*/1, /*boundary*/0,
 				   /*lowaddr*/BUS_SPACE_MAXADDR_32BIT,

Modified: head/sys/dev/aic7xxx/ahc_pci.c
==============================================================================
--- head/sys/dev/aic7xxx/ahc_pci.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/aic7xxx/ahc_pci.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -105,7 +105,6 @@ ahc_pci_attach(device_t dev)
                 ahc->flags |= AHC_39BIT_ADDRESSING;
 
 	/* Allocate a dmatag for our SCB DMA maps */
-	/* XXX Should be a child of the PCI bus dma tag */
 	error = aic_dma_tag_create(ahc, /*parent*/bus_get_dma_tag(dev),
 				   /*alignment*/1, /*boundary*/0,
 				   (ahc->flags & AHC_39BIT_ADDRESSING)

Modified: head/sys/dev/aic7xxx/ahd_pci.c
==============================================================================
--- head/sys/dev/aic7xxx/ahd_pci.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/aic7xxx/ahd_pci.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -107,7 +107,6 @@ ahd_pci_attach(device_t dev)
                 ahd->flags |= AHD_39BIT_ADDRESSING;
 
 	/* Allocate a dmatag for our SCB DMA maps */
-	/* XXX Should be a child of the PCI bus dma tag */
 	error = aic_dma_tag_create(ahd, /*parent*/bus_get_dma_tag(dev),
 				   /*alignment*/1, /*boundary*/0,
 				   (ahd->flags & AHD_39BIT_ADDRESSING)

Modified: head/sys/dev/buslogic/bt_pci.c
==============================================================================
--- head/sys/dev/buslogic/bt_pci.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/buslogic/bt_pci.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -172,7 +172,6 @@ bt_pci_attach(device_t dev)
 	}
 
 	/* Allocate a dmatag for our CCB DMA maps */
-	/* XXX Should be a child of the PCI bus dma tag */
 	if (bus_dma_tag_create(	/* PCI parent	*/ bus_get_dma_tag(dev),
 				/* alignemnt	*/ 1,
 				/* boundary	*/ 0,

Modified: head/sys/dev/dpt/dpt_pci.c
==============================================================================
--- head/sys/dev/dpt/dpt_pci.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/dpt/dpt_pci.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -132,7 +132,6 @@ dpt_pci_attach (device_t dev)
 	dpt_alloc(dev);
 
 	/* Allocate a dmatag representing the capabilities of this attachment */
-	/* XXX Should be a child of the PCI bus dma tag */
 	if (bus_dma_tag_create(	/* PCI parent */ bus_get_dma_tag(dev),
 				/* alignemnt */	1,
 				/* boundary  */	0,

Modified: head/sys/dev/iir/iir_pci.c
==============================================================================
--- head/sys/dev/iir/iir_pci.c	Mon Mar 12 18:56:16 2012	(r232881)
+++ head/sys/dev/iir/iir_pci.c	Mon Mar 12 19:29:32 2012	(r232882)
@@ -317,7 +317,6 @@ iir_pci_attach(device_t dev)
     gdt->sc_test_busy = gdt_mpr_test_busy;
 
     /* Allocate a dmatag representing the capabilities of this attachment */
-    /* XXX Should be a child of the PCI bus dma tag */
     if (bus_dma_tag_create(/*parent*/bus_get_dma_tag(dev),
                            /*alignemnt*/1, /*boundary*/0,
                            /*lowaddr*/BUS_SPACE_MAXADDR_32BIT,


More information about the svn-src-all mailing list