svn commit: r237348 - head/usr.bin/makewhatis

Xin LI delphij at FreeBSD.org
Wed Jun 20 23:53:37 UTC 2012


Author: delphij
Date: Wed Jun 20 23:53:36 2012
New Revision: 237348
URL: http://svn.freebsd.org/changeset/base/237348

Log:
  Currently the code uses gzFile * for a zlib file descriptor, which
  is not correct.  The code works by accident because gzFile is
  currently defined as void *, and internally it would be casted from
  or to its real type.
  
  A newer version of zlib will instead define it as a pointer to a
  specific type pointer (namely, struct gzFile_s *).  This therefore
  would cause stricter checks and compiler would catch this type
  mismatch.
  
  This change does not cause any changes to the resulting binary,
  as validated with md5(1).
  
  MFC after:	3 days

Modified:
  head/usr.bin/makewhatis/makewhatis.c

Modified: head/usr.bin/makewhatis/makewhatis.c
==============================================================================
--- head/usr.bin/makewhatis/makewhatis.c	Wed Jun 20 23:47:48 2012	(r237347)
+++ head/usr.bin/makewhatis/makewhatis.c	Wed Jun 20 23:53:36 2012	(r237348)
@@ -693,7 +693,7 @@ enum { STATE_UNKNOWN, STATE_MANSTYLE, ST
 static void
 process_page(struct page_info *page, char *section_dir)
 {
-	gzFile *in;
+	gzFile in;
 	char buffer[4096];
 	char *line;
 	StringList *names;


More information about the svn-src-all mailing list