svn commit: r237223 - head/sys/dev/fb

Gennady Proskurin gprspb at mail.ru
Wed Jun 20 09:19:16 UTC 2012


On Wed, Jun 20, 2012 at 05:59:07PM +0930, Daniel O'Connor wrote:
> 
> On 20/06/2012, at 17:11, Gennady Proskurin wrote:
> > On Tue, Jun 19, 2012 at 05:27:11AM +0000, Poul-Henning Kamp wrote:
> >> In message <68FBE843-7337-4C90-B01F-E0CAABB62BCD at gsoft.com.au>, "Daniel O'Conno
> >> r" writes:
> >> 
> >>>> If size is odd, this does not copy the last byte. Not sure, whether =
> >>> this is intended.
> >> 
> >> Feel free to improve...
> > 
> > <fb.patch>
> 
> 
> Surely if you pass it an odd size you made a mistake - either the wrong function was used or you computed the size incorrectly.

Functions are called "bcopy_io" and so, such names tell nothing about data size
they work with ("copyw" tells something). If it is not supposed to work with
odd size, I agree, my patch is overkill, something like KASSERT (or just
one-line comment) is better.

I just wanted to be sure, that potential bug in this code is known to
developpers.



More information about the svn-src-all mailing list