svn commit: r236935 - head/sys/kern

Pawel Jakub Dawidek pjd at FreeBSD.org
Wed Jun 13 11:15:05 UTC 2012


On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote:
> http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch
> 
> David reported that previous version of the patch fixed panic he was
> experiencing, so I consider the patch tested.

Looks good, one (hopefully last) minor nit. I'd change this comment:

	 * Search the bitmap for a free descriptor starting at minfd. If none
	 * is found, try to grow the file table.

To something like this:

	 * Search the bitmap for a free descriptor starting at minfd.
	 * If none is found, grow the file table.

'try' is a bit misleading for my taste, as it suggest that growing the
file table might fail, I think.

That's all from me:)

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120613/b89676fe/attachment.pgp


More information about the svn-src-all mailing list