svn commit: r238943 - head/sys/dev/acpica

Alexander Motin mav at FreeBSD.org
Tue Jul 31 17:07:22 UTC 2012


On 31.07.2012 19:12, Sean Bruno wrote:
> On Tue, 2012-07-31 at 03:58 -0700, Alexander Motin wrote:
>> To help with diagnostics, add C-state type into
>> dev.cpu.X.cx_supported.
>
> Pretty sure that this breaks /etc/rc.d/power_profile

No, it doesn't. I've checked it beforehand. At least in my case variable 
was correctly set to C3.

> Andiry and I went back and forth on this specific thing quite a bit.  If
> you note my commit/revert at svn r238004 and r238009 where I did a
> similar thing and then had to yank it out.
>
> there's a lot of discussion around this point on the acpi mailing lists.
> http://lists.freebsd.org/pipermail/freebsd-acpi/2012-July/007645.html

I knew about that change and its revert. But it was much more invasive, 
substituting C-state index with C-state type, that I also consider 
incorrect. My change is much more simple. Yes, it may affect some POLA, 
but that is all. I wanted to do this for several years, and I believe 
that in this case benefits overweight negative side. But if someone tell 
I should back it out, I will.

-- 
Alexander Motin


More information about the svn-src-all mailing list