svn commit: r238828 - head/sys/sys

Gleb Smirnoff glebius at FreeBSD.org
Fri Jul 27 11:20:29 UTC 2012


On Fri, Jul 27, 2012 at 02:12:37PM +0300, Konstantin Belousov wrote:
K> On Fri, Jul 27, 2012 at 09:16:48AM +0000, Gleb Smirnoff wrote:
K> > Author: glebius
K> > Date: Fri Jul 27 09:16:48 2012
K> > New Revision: 238828
K> > URL: http://svn.freebsd.org/changeset/base/238828
K> > 
K> > Log:
K> >   Add assertion for refcount overflow.
K> >   
K> >   Submitted by:	Andrey Zonov <andrey zonov.org>
K> >   Reviewed by:	kib
K> It was discussed rather then reviewed.
K> 
K> I suggest that the assert may be expressed as a check after the increment,
K> which verifies that counter is != 0. This allows to avoid namespace
K> pollution due to limits.h.

Hmm, overflowing unsigned is a defined behavior in C. If Bruce agrees,
then I'm happy with KASSERT after increment.

-- 
Totus tuus, Glebius.


More information about the svn-src-all mailing list