svn commit: r238614 - in head/sys: kern sys

Pawel Jakub Dawidek pjd at FreeBSD.org
Thu Jul 19 20:21:44 UTC 2012


On Thu, Jul 19, 2012 at 10:22:55AM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Thu Jul 19 10:22:54 2012
> New Revision: 238614
> URL: http://svn.freebsd.org/changeset/base/238614
> 
> Log:
>   Implement F_DUPFD_CLOEXEC command for fcntl(2), specified by SUSv4.
>   
>   PR:	  standards/169962
>   Submitted by:	Jukka A. Ukkonen <jau iki fi>
>   MFC after:	1 week
[...]
> +	if ((flags & DUP_CLOEXEC) != 0)
> +		fdp->fd_ofileflags[new] = fdp->fd_ofileflags[old] | UF_EXCLOSE;
> +	else
> +		fdp->fd_ofileflags[new] = fdp->fd_ofileflags[old] & ~UF_EXCLOSE;
>  	fdp->fd_ofileflags[new] = fdp->fd_ofileflags[old] &~ UF_EXCLOSE;

It seems that you forgot to remove the line above, which results in
always removing the UF_EXCLOSE flag.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120719/67f5619d/attachment.pgp


More information about the svn-src-all mailing list