svn commit: r238033 - head/sys/powerpc/booke

Marcel Moolenaar marcel at FreeBSD.org
Mon Jul 2 21:21:13 UTC 2012


Author: marcel
Date: Mon Jul  2 21:21:12 2012
New Revision: 238033
URL: http://svn.freebsd.org/changeset/base/238033

Log:
  Fix a typo that resulted in or-ing PTE_UW twice whrn PTE_SW was needed.
  Note that setting the PTE_MODIFIED bit based on whether write is possible
  is incorrect. We should set PTE_MODIFIED based on whether the access
  is a write operation.

Modified:
  head/sys/powerpc/booke/trap_subr.S

Modified: head/sys/powerpc/booke/trap_subr.S
==============================================================================
--- head/sys/powerpc/booke/trap_subr.S	Mon Jul  2 21:18:09 2012	(r238032)
+++ head/sys/powerpc/booke/trap_subr.S	Mon Jul  2 21:21:12 2012	(r238033)
@@ -668,7 +668,7 @@ tlb_fill_entry:
 	lwarx	%r21, %r23, %r25		/* get pte->flags */
 	oris	%r21, %r21, PTE_REFERENCED at h	/* set referenced bit */
 
-	andi.	%r22, %r21, (PTE_UW | PTE_UW)@l	/* check if writable */
+	andi.	%r22, %r21, (PTE_SW | PTE_UW)@l	/* check if writable */
 	beq	2f
 	oris	%r21, %r21, PTE_MODIFIED at h	/* set modified bit */
 2:


More information about the svn-src-all mailing list