svn commit: r230252 - head/sys/fs/tmpfs

[Mikolaj Golub]

On Tue, 17 Jan 2012 19:10:31 +0200 Jaakko Heinonen wrote:

 JH> On 2012-01-17, Kevin Lo wrote:
 >>   Return EOPNOTSUPP since we only support update mounts for NFS export.
 >>   
 >> @@ -150,8 +150,12 @@ tmpfs_mount(struct mount *mp)
 >>                  return (EINVAL);
 >>  
 >>          if (mp->mnt_flag & MNT_UPDATE) {
 >> +                /*
 >> +                 * Only support update mounts for NFS export.
 >> +                 */
 >>                  if (vfs_flagopt(mp->mnt_optnew, "export", NULL, 0))
 >>                          return (0);
 >> +                return (EOPNOTSUPP);
 >>          }

 JH> This doesn't look correct. As long as the option list includes the
 JH> "export" option, all options are accepted. An example:

 JH> # mount -u -o ro /mnt
 JH> mount: tmpfs : Operation not supported
 JH> # mount -u -o ro,export /mnt
 JH> #

There is no error but ro is still ignored, so this is only the issue with
reporting. Note, the code for nullfs (as an example) looks the same.

It could be fixed with vfs_filteropt(9), not sure if this is worth doing here
though.

-- 
Mikolaj Golub