svn commit: r230354 - head/usr.sbin/makefs

[Eitan Adler]

On Thu, Jan 19, 2012 at 10:32 PM, Hiroki Sato <hrs at freebsd.org> wrote:
> Eitan Adler <eadler at FreeBSD.org> wrote
>  in <201201200138.q0K1cSou016739 at svn.freebsd.org>:
>
> ea> Author: eadler
> ea> Date: Fri Jan 20 01:38:28 2012
> ea> New Revision: 230354
> ea> URL: http://svn.freebsd.org/changeset/base/230354
> ea>
> ea> Log:
> ea>   Fix a variety of warnings when compiling with gcc46
> ea>
> ea>   Approved by:      dim, cperciva (mentor, blanket for pre-mentorship already-approved commits)
> ea>   MFC after:        3 days
> ea>
> ea> Modified:
> ea>   head/usr.sbin/makefs/cd9660.c
>
>  Removing the dot handling part and leaving a comment in lines
>  1106-1117 make people confused.

I missed that - sorry.

>  In addition to that, I personally don't think this should be removed
>  because our cd9660.c is still based on NetBSD's one in any
>  way---bugfixes on our side have been reported to the upstream and we
>  will import useful changes from there if any.  Although the current
>  dot handling is useless, keeping the difference between the two small
>  still has a meaning.

I was was unaware this code was contributed. I just looked at the
NetBSD version and I don't think it suffers from the same problem -
the loop appears to be used later. If that is because of some other
bug fix which could be upstreamed that would be great. On the other
hand I would like to continue with my goal of making the non-contrib
world compilable with CC=gcc46.

Should I revert this commit?


-- 
Eitan Adler
Ports committer
X11, Bugbusting teams