svn commit: r230230 - head/sys/dev/random

[Mark Murray]

Andrey Chernov writes:
> On Mon, Jan 16, 2012 at 08:18:10PM +0000, David Schultz wrote:
> > Author: das
> > Date: Mon Jan 16 20:18:10 2012
> > New Revision: 230230
> > URL: http://svn.freebsd.org/changeset/base/230230
> > 
> > Log:
> >   Generate a warning if the kernel's arc4random() is seeded with bogus entropy.
> 
> While you are here, could you review/commit my patch to fix bad 31bit
> arc4rand() seeding, please?
> 
> --- yarrow.c.bak	2011-09-26 07:35:48.000000000 +0400
> +++ yarrow.c	2012-01-18 10:13:47.000000000 +0400

This is the wrong place for this; it may achieve the desired result, but
the file is where the Yarrow algorithm is implepeneted; ARC4 reseeds are
not a part of that, which makes this proposal a layering violation at
best, and an unwarranted dependancy at worst.

Look at the function random_yarrow_unblock(). Thats where yopu want to
be doing this. This function is where the random device is unblocked
once safely seeded.

M
--
Mark R V Murray
Cert APS(Open) Dip Phys(Open) BSc Open(Open) BSc(Hons)(Open)
Pi: 132511160