svn commit: r230125 - head/sys/kern

Doug Barton dougb at FreeBSD.org
Tue Jan 17 19:07:39 UTC 2012


On 01/17/2012 10:48, John Baldwin wrote:
> On Tuesday, January 17, 2012 12:29:06 pm Andriy Gapon wrote:
>> on 17/01/2012 19:12 Eitan Adler said the following:
>>> To me seeing "(null)" from the output of printf indicates "There is a
>>> bug here, printf should never be given a NULL argument.".
>>> However, given that it isn't undefined here, and the objections I've
>>> received I will revert this part of the change when I get home.
>>
>> Would this be worth the hassle now that the change is already committed?
> 
> Probably not, though at some point if the printf is reworked for some other
> reason it could be removed then.  I don't think we need to add more special
> case handling for NULL string pointers passed to kernel printf in the future,
> however.

If it needs to be changed, it should be done sooner than later. It's not
as if we're carving the bits out of stone after all. :)



-- 

	It's always a long day; 86400 doesn't fit into a short.

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/



More information about the svn-src-all mailing list