svn commit: r229908 - head/usr.bin/brandelf

Pawel Jakub Dawidek pjd at FreeBSD.org
Tue Jan 10 08:22:18 UTC 2012


On Tue, Jan 10, 2012 at 02:58:29AM +0000, Eitan Adler wrote:
> Author: eadler (ports committer)
> Date: Tue Jan 10 02:58:29 2012
> New Revision: 229908
> URL: http://svn.freebsd.org/changeset/base/229908
> 
> Log:
>   Fix warning when compiling with gcc46:
>   	 error: variable 'verbose' set but not use

Maybe we should remove -v from the manual page as well or document as no-op?
I'd still leave it in the code though, so there is no POLA violation.

>   Approved by:	dim
>   MFC after:      3 days
> 
> Modified:
>   head/usr.bin/brandelf/brandelf.c
> 
> Modified: head/usr.bin/brandelf/brandelf.c
> ==============================================================================
> --- head/usr.bin/brandelf/brandelf.c	Tue Jan 10 02:58:20 2012	(r229907)
> +++ head/usr.bin/brandelf/brandelf.c	Tue Jan 10 02:58:29 2012	(r229908)
> @@ -64,7 +64,7 @@ main(int argc, char **argv)
>  	const char *strtype = "FreeBSD";
>  	int type = ELFOSABI_FREEBSD;
>  	int retval = 0;
> -	int ch, change = 0, verbose = 0, force = 0, listed = 0;
> +	int ch, change = 0, force = 0, listed = 0;
>  
>  	while ((ch = getopt(argc, argv, "f:lt:v")) != -1)
>  		switch (ch) {
> @@ -84,7 +84,7 @@ main(int argc, char **argv)
>  			listed = 1;
>  			break;
>  		case 'v':
> -			verbose = 1;
> +			/* does nothing */
>  			break;
>  		case 't':
>  			if (force)

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://yomoli.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120110/d15f324f/attachment.pgp


More information about the svn-src-all mailing list