svn commit: r232304 - head/sys/fs/nullfs

Konstantin Belousov kib at FreeBSD.org
Wed Feb 29 15:18:05 UTC 2012


Author: kib
Date: Wed Feb 29 15:18:04 2012
New Revision: 232304
URL: http://svn.freebsd.org/changeset/base/232304

Log:
  Document that null_nodeget() cannot take shared-locked lowervp due to
  insmntque() requirements.
  
  Tested by:	pho
  MFC after:	1 week

Modified:
  head/sys/fs/nullfs/null_subr.c

Modified: head/sys/fs/nullfs/null_subr.c
==============================================================================
--- head/sys/fs/nullfs/null_subr.c	Wed Feb 29 15:15:36 2012	(r232303)
+++ head/sys/fs/nullfs/null_subr.c	Wed Feb 29 15:18:04 2012	(r232304)
@@ -209,7 +209,11 @@ null_nodeget(mp, lowervp, vpp)
 	struct vnode *vp;
 	int error;
 
-	ASSERT_VOP_LOCKED(lowervp, "lowervp");
+	/*
+	 * The insmntque1() call below requires the exclusive lock on
+	 * the nullfs vnode.
+	 */
+	ASSERT_VOP_ELOCKED(lowervp, "lowervp");
 	KASSERT(lowervp->v_usecount >= 1, ("Unreferenced vnode %p\n", lowervp));
 
 	/* Lookup the hash firstly */


More information about the svn-src-all mailing list