svn commit: r231814 - in head/sys: kern sys

[Kenneth D. Merry]

On Thu, Feb 16, 2012 at 11:13:09 +0200, Andriy Gapon wrote:
> on 16/02/2012 11:00 Andriy Gapon said the following:
> > on 16/02/2012 10:53 Julian Elischer said the following:
> >> Bruce, this is a good example of a legitimate gripe going un-noticed because
> >> you didn't shout loud enough at the right time, at the right people.
> >> It's been about 20 years since we started working on this but I've finally
> >> come to the point of saying that we need you to do more when you see problems.
> >> object officially if you think things should be backed out!
> >>
> >> your reasons here seem sound, so it's hard to see why you haven't been more
> >> public about it.
> > 
> > Just for the record: Bruce and I voiced opinions against the commit when it went
> > in after a rather short notice for such an important thing.  The opinions
> > can be found in the archives of these lists.
> 
> To be more precise: s/opinions against/concerns about behavior in the edge cases/.
> 
> For me personally the immediate benefits in the common situations outweighed the
> problems in the edge cases, although I still believe that we can get the former
> without sacrifices in the latter.

I will happily back the message buffer locking changes out if you and Bruce
agree that that is the best thing to do.

I can also review any proposed fixes to the message buffer locking code,
but I really don't have the bandwidth right now to come up with the "real"
solution.

Sorry I didn't get around to dealing with it, I should have said something
months ago.

Now that you know a fix won't be coming from me, you two can let me know
whether you'd like the changes backed out, or you are certainly free to
commit a solution yourselves.

Ken
-- 
Kenneth Merry
ken at FreeBSD.org