svn commit: r230869 - head/usr.sbin/daemon

Pawel Jakub Dawidek pjd at FreeBSD.org
Sun Feb 12 20:09:39 UTC 2012


On Sat, Feb 11, 2012 at 12:35:27PM +0200, Mikolaj Golub wrote:
> Thank you. Here are the patches I would like to commit if there are no
> objections or other suggestions:
> 
> http://people.freebsd.org/~trociny/daemon/daemon.spawn.1.patch

The patch looks good to me. I'd just fix style nit: please compare
'pidfile' with NULL, don't treat it as bool.

> http://people.freebsd.org/~trociny/daemon/daemon.SIGTERM.1.patch
> http://people.freebsd.org/~trociny/daemon/daemon.restart.1.patch

I'd prefer not to be listed in 'Discussed by' for those two patches.
As I said before, I'm not convinced those are desired functionalities.
I don't object strongly against them, but having my name there suggests
we reached some consensus and we didn't:)

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120212/11674753/attachment.pgp


More information about the svn-src-all mailing list