svn commit: r230869 - head/usr.sbin/daemon

[Mikolaj Golub]

On Mon, 6 Feb 2012 09:27:06 +0100 Pawel Jakub Dawidek wrote:

 PJD> For the patch itself.

 PJD> You don't have to have two separate cases depending on request for
 PJD> pidfile. You can specify NULL pfh to the pidfile functions.
 PJD> Even in example from the manual page when pfh is NULL there is a case
 PJD> where we warn, but continue execution and call pidfile functions.
 PJD> This should simplify the code.

 PJD> If you do that (actually even if you don't), remember to either use
 PJD> warn(3) before pidfile_remove(3) and exit(3) after or preserve errno
 PJD> before calling pidfile_remove(3), as pidfile_remove(3) can modify it if
 PJD> unlink(2) is unsuccessful or pfh is NULL.

Thanks. The updated version is attached.

-- 
Mikolaj Golub

-------------- next part --------------
A non-text attachment was scrubbed...
Name: daemon.c.2.patch
Type: text/x-patch
Size: 2459 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20120206/731b8b1a/daemon.c.2.bin