svn commit: r244271 - head/usr.sbin/iostat

[Mikolaj Golub]

On Sat, Dec 15, 2012 at 05:00:39PM -0800, Adrian Chadd wrote:
> Hi,
> 
> People may have scripts based on the current output.
> 
> You should have introduced a new parameter which modifies the output
> behaviour in the way you wanted, rather than modifying the existing
> behaviour.
> 
> Please consider reverting your change (which is a good idea, btw) and
> adding a new modifier that outputs the value(s), rather than a %age.

It is a pity that this question did not arise when I published this
patch on hackers@:

 http://lists.freebsd.org/pipermail/freebsd-hackers/2012-September/040558.html

I got then only one (private) reply from David Wolfskill, who though
it was a good idea but had to go only to head (10.x) due to the
changed behavior.

I don't have plans to MFC this.

I will revert the change, if other people also think I have to.

I wont add a new modifier introducing yet another ugliness to iostat(8):
iostat -Ix behavior before the change contradicted what was described
in the man:

  -I    Display total statistics for a given time period, rather than aver-
        age statistics for each second during that time period.

In my opinion, preserving the wrong behaviour and adding yet another
switch to have the desirable one is worse. So I'd rather just revert
this back and keep using my sysutils/devstat utility, which already
gives me what I want.

-- 
Mikolaj Golub