svn commit: r244154 - head/bin/ps

[Pawel Jakub Dawidek]

On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote:
> On Wed, Dec 12, 2012 at 03:45:04PM +0000, Pawel Jakub Dawidek wrote:
> > Author: pjd
> > Date: Wed Dec 12 15:45:03 2012
> > New Revision: 244154
> > URL: http://svnweb.freebsd.org/changeset/base/244154
> > 
> > Log:
> >   Use kern.max_pid sysctl to obtain maximum PID number instead of using local
> >   define.
> It is pid_max, not max_pid.
> 
> But the change is wrong. The kern.pid_max only limits newly allocated pids,
> it does not magically moves existing pids, which are out of range, to the
> limited region. See the corresponding commit log for the description.
> It was added to make it easier to run FreeBSD 1.x binaries on the modern
> kernels.

I saw CTLFLAG_TUN on the sysctl and assumed it is read-only...
How about defining BSD_PID_MAX in sys/proc.h, which would be visible by
userland as well and setting PID_MAX to BSD_PID_MAX?

This would also help bsnmpd.

	http://people.freebsd.org/~pjd/patches/PID_MAX.patch

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20121213/aa64d898/attachment.sig>