svn commit: r244171 - head/sys/dev/uart
Oleksandr Tymoshenko
gonzo at FreeBSD.org
Thu Dec 13 03:35:47 UTC 2012
Author: gonzo
Date: Thu Dec 13 03:35:47 2012
New Revision: 244171
URL: http://svnweb.freebsd.org/changeset/base/244171
Log:
Prevent possible usage of uninitialized pbase variable by checking
return value of fdt_get_range
Modified:
head/sys/dev/uart/uart_bus_fdt.c
Modified: head/sys/dev/uart/uart_bus_fdt.c
==============================================================================
--- head/sys/dev/uart/uart_bus_fdt.c Thu Dec 13 03:34:24 2012 (r244170)
+++ head/sys/dev/uart/uart_bus_fdt.c Thu Dec 13 03:35:47 2012 (r244171)
@@ -206,8 +206,10 @@ uart_cpu_getdev(int devtype, struct uart
err = fdt_regsize(node, &start, &size);
if (err)
return (ENXIO);
+ err = fdt_get_range(OF_parent(node), 0, &pbase, &psize);
+ if (err)
+ pbase = 0;
- fdt_get_range(OF_parent(node), 0, &pbase, &psize);
start += pbase;
return (bus_space_map(di->bas.bst, start, size, 0, &di->bas.bsh));
More information about the svn-src-all
mailing list