svn commit: r243999 - head/sys/kern

[Pawel Jakub Dawidek]

On Sat, Dec 08, 2012 at 02:24:03PM +1100, Bruce Evans wrote:
> On Fri, 7 Dec 2012, Pawel Jakub Dawidek wrote:
> 
> > Log:
> >  Configure UMA warnings for the following zones:
> >  - unp_zone: kern.ipc.maxsockets limit reached
> >  - socket_zone: kern.ipc.maxsockets limit reached
> 
> These still have part of the poor grammar, with a redundant "limit".
> 
> I thought that the limit on the number of sockets was on the total
> number of sockets.  The documentation of its sysctl in sysctl -d still
> doesn't say that it is only a per-zone limit (unless you changed this
> recently):
> 
>      kern.ipc.maxsockets: Maximum number of sockets avaliable

All sockets are allocated from one zone: socket_zone, so
kern.ipc.maxsockets is both socket_zone limit and a global limit.

> >  - zone_mbuf: kern.ipc.nmbufs limit reached
> >  - zone_clust: kern.ipc.nmbclusters limit reached
> >  - zone_jumbop: kern.ipc.nmbjumbop limit reached
> >  - zone_jumbo9: kern.ipc.nmbjumbo9 limit reached
> >  - zone_jumbo16: kern.ipc.nmbjumbo16 limit reached
> 
> Same bug, except the sysctl names are missing "lim" or "max" and repeating
> "limit" works around this bug a little.  They are all for limits on
> numbers, but there names only say "n" (number). [...]

I'm sure you are aware of the fact that sysctl names are part of
API/ABI and changing them is not something that can be done without good
reason.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20121208/15b3919b/attachment.sig>