svn commit: r243942 - stable/9/sbin/fsck_msdosfs

Alfred Perlstein bright at mu.org
Thu Dec 6 17:00:55 UTC 2012


On 12/6/12 12:35 AM, Jaakko Heinonen wrote:
> Author: jh
> Date: Thu Dec  6 08:35:46 2012
> New Revision: 243942
> URL: http://svnweb.freebsd.org/changeset/base/243942
>
> Log:
>    MFC r242511: Print a newline after the error message.
>    
>    PR:		bin/168447
>
> Modified:
>    stable/9/sbin/fsck_msdosfs/check.c
> Directory Properties:
>    stable/9/sbin/fsck_msdosfs/   (props changed)
>
> Modified: stable/9/sbin/fsck_msdosfs/check.c
> ==============================================================================
> --- stable/9/sbin/fsck_msdosfs/check.c	Thu Dec  6 08:32:28 2012	(r243941)
> +++ stable/9/sbin/fsck_msdosfs/check.c	Thu Dec  6 08:35:46 2012	(r243942)
> @@ -68,6 +68,7 @@ checkfilesys(const char *fname)
>   
>   	if (dosfs < 0) {
>   		perror("Can't open");
> +		printf("\n");
>   		return 8;
>   	}
>   
>

I think perror writes to STDERR, printf to STDOUT.  (am I wrong?)

Does fsck_msdosfs tie the two together?

You might better use warn()?

sorry if this is superfluous concern, it just popped out as potentially 
wrong.

-Alfred


More information about the svn-src-all mailing list