svn commit: r226947 - in head/sys: dev/esp sparc64/sbus

Alexey Dokuchaev danfe at FreeBSD.org
Mon Oct 31 04:25:26 UTC 2011


On Sun, Oct 30, 2011 at 09:17:42PM +0000, Marius Strobl wrote:
> Author: marius
> Date: Sun Oct 30 21:17:42 2011
> New Revision: 226947
> URL: http://svn.freebsd.org/changeset/base/226947
> 
> Log:
>   - Use device_t rather than the NetBSDish struct device.

Hmm, I though that style(9) advises against this practice:

    Avoid using typedefs for structure types.  Typedefs are problematic
    because they do not properly hide their underlying type; [...]

    When convention requires a typedef, make its name match the struct tag.
    Avoid typedefs ending in _t, except as specified in Standard C or by
    POSIX.

Does these rules not apply for struct device for some reason?

./danfe


More information about the svn-src-all mailing list