svn commit: r226359 - head/usr.bin/look

Colin Percival cperciva at freebsd.org
Sun Oct 16 17:39:56 UTC 2011


On 10/14/11 00:24, Ed Schouten wrote:
> Log:
>   Build look(1) with WARNS=6.
>
> -		if (sb.st_size > SIZE_T_MAX)
> +		if (sb.st_size > (off_t)SIZE_T_MAX)
>  			errx(2, "%s: %s", file, strerror(EFBIG));

This might make look(1) build, but on a 64-bit machine it also makes look(1)
fail with "File too large" whenever it's larger than (int64_t)(UINT64_MAX) = -1
bytes long.

Please fix. :-)

-- 
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid


More information about the svn-src-all mailing list