svn commit: r227474 - head/sys/amd64/include

Peter Jeremy peterjeremy at acm.org
Mon Nov 14 05:31:26 UTC 2011


On 2011-Nov-12 20:16:07 +0000, David Chisnall <theraven at FreeBSD.org> wrote:
>  Fix SIGATOMIC_M{IN,AX} on x86-64.

Thanks for that.  I have two comments:

1) Could you please wrap your log messages so that lines do not exceed
80 characters.

> /* Limits of sig_atomic_t. */
>-#define	SIG_ATOMIC_MIN	INT32_MIN
>-#define	SIG_ATOMIC_MAX	INT32_MAX
>+#define	SIG_ATOMIC_MIN	LONG_MIN
>+#define	SIG_ATOMIC_MAX	LONG_MAX

2) As far as I can see, all other defines in _stdint.h, across all
architectures, have explicit lengths, so I believe this would be
better specified as:

#define	SIG_ATOMIC_MIN	INT64_MIN
#define	SIG_ATOMIC_MAX	INT64_MAX

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20111114/913c652b/attachment.pgp


More information about the svn-src-all mailing list