svn commit: r219559 - in head/sys: amd64/linux32 compat/freebsd32 i386/linux kern

[Artem Belevich]

On Sun, Mar 13, 2011 at 6:15 AM, Alexander Leidinger
<Alexander at leidinger.net> wrote:
> On Sat, 12 Mar 2011 22:24:09 -0800 Artem Belevich <fbsdlist at src.cx>
> wrote:
>
>> >> Modified: head/sys/i386/linux/syscalls.master
>> >> -                                 l_handler_t handler); }
>> >> +                                 void *handler); }
>> >
>> > What's wrong with l_handler_t?
>>
>> I don't recall the details, but I believe that the way l_handler_t is
>> defined resulted in compilation errors in generated glue code. Glue
>> generation code relies on '*' before the argument name in order to
>> tell scalars from pointers. l_handler_t was interpreted as a scalar
>> and on i386 where l_handler_t is a pointer, it produced compilation
>> warning.
>
> What about documenting it with a comment nearby?

How about this:

handle is l_handle_t, but the makesyscalls.sh relies on '*' to tell
pointers from scalars when it generates DTrace glue code, so void* had
to be used.

I don't have commit bit, though.

--Artem