svn commit: r223488 - head/lib/libstand

Alexander Kabaev kabaev at gmail.com
Fri Jun 24 15:48:06 UTC 2011


On Fri, 24 Jun 2011 03:50:55 +0000 (UTC)
Craig Rodrigues <rodrigc at FreeBSD.org> wrote:

Hi,

> +		if (d->xid != 1) {
> +			return (-1);
> +		}

this is distinctly NOT what I sent to you and would rather not take
credit for consequences. What you are doing here is not dropping the
packet, you are returning error from read and with errno in unknown
state on top of that. Why did this have to change and why there is no
mention of that in the commit message?

-- 
Alexander Kabaev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20110624/116aa240/signature.pgp


More information about the svn-src-all mailing list