svn commit: r223138 - head/sys/ufs/ffs

[Bruce Evans]

On Thu, 16 Jun 2011, Tai-hwa Liang wrote:

> On Thu, 16 Jun 2011, Bruce Evans wrote:

>> It might be a style bug (like typedefing a struct) to use enums for
>> anything.  They are impossible to declare opaquely.
>
>  Does that mean we have to #include <sys/vnode.h> in userland 
> makefs/ffs/ffs_bswap.c?

It means that you should implement headers properly, so that they don't
depend on other headers to begin with or grow dependencies on other
headers.  Though the should-be-kernel-only header <sys/vnode.h> has some
parts including `enum vtype' that have already escaped to userland, other
headers shouldn't grow dependencies on these.

Bruce