svn commit: r218042 - head/sbin/hastd

[Pawel Jakub Dawidek]

Author: pjd
Date: Fri Jan 28 21:51:40 2011
New Revision: 218042
URL: http://svn.freebsd.org/changeset/base/218042

Log:
  Add comments to places where we treat errors as ciritical, but it is possible
  to handle them more gracefully.
  
  MFC after:	1 week

Modified:
  head/sbin/hastd/primary.c

Modified: head/sbin/hastd/primary.c
==============================================================================
--- head/sbin/hastd/primary.c	Fri Jan 28 21:48:15 2011	(r218041)
+++ head/sbin/hastd/primary.c	Fri Jan 28 21:51:40 2011	(r218042)
@@ -796,6 +796,7 @@ hastd_primary(struct hast_resource *res)
 	 * Create communication channel between parent and child.
 	 */
 	if (proto_client("socketpair://", &res->hr_ctrl) < 0) {
+		/* TODO: There's no need for this to be fatal error. */
 		KEEP_ERRNO((void)pidfile_remove(pfh));
 		pjdlog_exit(EX_OSERR,
 		    "Unable to create control sockets between parent and child");
@@ -804,6 +805,7 @@ hastd_primary(struct hast_resource *res)
 	 * Create communication channel between child and parent.
 	 */
 	if (proto_client("socketpair://", &res->hr_event) < 0) {
+		/* TODO: There's no need for this to be fatal error. */
 		KEEP_ERRNO((void)pidfile_remove(pfh));
 		pjdlog_exit(EX_OSERR,
 		    "Unable to create event sockets between child and parent");
@@ -811,6 +813,7 @@ hastd_primary(struct hast_resource *res)
 
 	pid = fork();
 	if (pid < 0) {
+		/* TODO: There's no need for this to be fatal error. */
 		KEEP_ERRNO((void)pidfile_remove(pfh));
 		pjdlog_exit(EX_TEMPFAIL, "Unable to fork");
 	}