svn commit: r217048 - head/share/man/man9

Colin Percival cperciva at freebsd.org
Thu Jan 6 12:56:11 UTC 2011


On 01/06/11 04:47, John Baldwin wrote:
> On Thursday, January 06, 2011 4:02:43 am Julian Elischer wrote:
>> On 1/6/11 12:33 AM, Edward Tomasz Napierala wrote:
>>> -Code that cannot be reached should have a
>>> -.Li NOTREACHED
>>> -comment.
> 
> Clutter.  It should be very obvious that exit(), err*(), pthread_exit(), 
> kthread_exit(), kproc_exit() and even usage() all terminate without returning 
> (the last not required, just a very common convention).  [...]

However, it might not be so obvious following long 'for (;;)' loops which
return rather than breaking.  I'd prefer to see the remark stay in style(9)
with an added "in cases where this isn't immediately obvious from the
surrounding code" clause.

-- 
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid


More information about the svn-src-all mailing list