svn commit: r216994 - stable/7/sys/dev/mii

Marius Strobl marius at FreeBSD.org
Wed Jan 5 11:46:18 UTC 2011


Author: marius
Date: Wed Jan  5 11:46:18 2011
New Revision: 216994
URL: http://svn.freebsd.org/changeset/base/216994

Log:
  MFC: r216623
  
  - Add a comment regarding the fact that as documented in the datasheet
    manual 1000BASE-T modes of DP83865 only work together with other National
    Semiconductor PHYs.
  - Spell 10BASE-T correctly
  - Remove some redundant braces.

Modified:
  stable/7/sys/dev/mii/nsgphy.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/dev/mii/nsgphy.c
==============================================================================
--- stable/7/sys/dev/mii/nsgphy.c	Wed Jan  5 11:46:17 2011	(r216993)
+++ stable/7/sys/dev/mii/nsgphy.c	Wed Jan  5 11:46:18 2011	(r216994)
@@ -140,11 +140,15 @@ nsgphy_attach(device_t dev)
 	mii_phy_reset(sc);
 
 	/*
-	 * NB: the PHY has the 10baseT BMSR bits hard-wired to 0,
-	 * even though it supports 10baseT.
+	 * NB: the PHY has the 10BASE-T BMSR bits hard-wired to 0,
+	 * even though it supports 10BASE-T.
 	 */
 	sc->mii_capabilities = (PHY_READ(sc, MII_BMSR) |
-	    (BMSR_10TFDX | BMSR_10THDX)) & ma->mii_capmask;
+	    BMSR_10TFDX | BMSR_10THDX) & ma->mii_capmask;
+	/*
+	 * Note that as documented manual 1000BASE-T modes of DP83865 only
+	 * work together with other National Semiconductor PHYs.
+	 */
 	if (sc->mii_capabilities & BMSR_EXTSTAT)
 		sc->mii_extcapabilities = PHY_READ(sc, MII_EXTSR);
 


More information about the svn-src-all mailing list