svn commit: r218708 - head/sys/dev/ath/ath_hal/ar9002

Adrian Chadd adrian at
Thu Feb 17 13:02:02 UTC 2011

Author: adrian
Date: Tue Feb 15 13:29:52 2011
New Revision: 218708

  Disable flipping antennas for AR9280.
  Flipping antennas when doing 11n would cause all kinds of strange issues.
  Just don't do it for now and when it comes time to do it, don't do it here.


Modified: head/sys/dev/ath/ath_hal/ar9002/ar9280_attach.c
--- head/sys/dev/ath/ath_hal/ar9002/ar9280_attach.c	Tue Feb 15 12:42:18 2011	(r218707)
+++ head/sys/dev/ath/ath_hal/ar9002/ar9280_attach.c	Tue Feb 15 13:29:52 2011	(r218708)
@@ -705,11 +705,18 @@ ar9280FillCapabilityInfo(struct ath_hal 
 	return AH_TRUE;
+ * This has been disabled - having the HAL flip chainmasks on/off
+ * when attempting to implement 11n disrupts things. For now, just
+ * leave this flipped off and worry about implementing TX diversity
+ * for legacy and MCS0-7 when 11n is fully functioning.
+ */
 ar9280SetAntennaSwitch(struct ath_hal *ah, HAL_ANT_SETTING settings)
 #define ANTENNA0_CHAINMASK    0x1
 #define ANTENNA1_CHAINMASK    0x2
+#if 0
 	struct ath_hal_5416 *ahp = AH5416(ah);
 	/* Antenna selection is done by setting the tx/rx chainmasks approp. */
@@ -736,6 +743,7 @@ ar9280SetAntennaSwitch(struct ath_hal *a
 	HALDEBUG(ah, HAL_DEBUG_ANY, "%s: settings=%d, tx/rx chainmask=%d/%d\n",
 	    __func__, settings, ahp->ah_tx_chainmask, ahp->ah_rx_chainmask);
 	return AH_TRUE;
svn-src-head at mailing list
To unsubscribe, send any mail to "svn-src-head-unsubscribe at"

More information about the svn-src-all mailing list