svn commit: r218716 - head/sys/boot/common

John Baldwin jhb at
Tue Feb 15 21:35:44 UTC 2011

On Tuesday, February 15, 2011 4:18:41 pm Garrett Cooper wrote:
> On Tue, Feb 15, 2011 at 1:08 PM, Roman Divacky <rdivacky at> wrote:
> > I put there u_int8_t for a reason. That reason being that
> > it's basically struct direct->d_type which is u_int8_t
> > and not uint8_t.
>     Even though they're technically the same typedef'ed type (I'd keep
> style consistent according to the argument rdivacky is making). I
> guess this has about the same bikeshed-ability as my proposal to
> change all of the *chflags syscalls to use fflags_t instead of
> u_long/int/etc on freebsd-fs did a few weeks back.

No, this is different.  The uint8_t is correct.  C99 adopted uint*_t making 
u_int*_t deprecated.  In general all new code should use the C99 types.

John Baldwin

More information about the svn-src-all mailing list