svn commit: r218177 - head/sys/cddl/compat/opensolaris/sys

Bruce Evans brde at optusnet.com.au
Wed Feb 2 05:26:39 UTC 2011


On Tue, 1 Feb 2011, Garrett Cooper wrote:

> 2011/2/1 Alexander Kabaev <kabaev at gmail.com>:
>> On Tue, 1 Feb 2011 13:28:43 -0800
>> Garrett Cooper <gcooper at FreeBSD.org> wrote:
>>
>>> On Tue, Feb 1, 2011 at 1:15 PM, Alexander Kabaev <kan at freebsd.org>
>>> wrote:
>>>> Author: kan
>>>> Date: Tue Feb  1 21:15:35 2011
>>>> New Revision: 218177
>>>> URL: http://svn.freebsd.org/changeset/base/218177
>>>>
>>>> Log:
>>>>  Revert r218169 until it can be tested and fixed properly.
>>
>> The real fix from Martin will follow shortly.
>
>    This really needs to be resolved by rearchitecting clock_t to be
> 64-bit on amd64/i386, etc, or add the appropriate shims to handle
> overflow in our opensolaris compatibility layer.

Not really.  As I explained at length, the bug is mostly abusing clock_t
for something that it is not required to do and in fact doesn't do.  You
shouldn't change the ABI of clock_t just to make abuses work.

Bruce


More information about the svn-src-all mailing list