svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnmp...

Ben Kaduk minimarmot at gmail.com
Fri Dec 30 19:43:23 UTC 2011


On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein <uqs at freebsd.org> wrote:
> Author: uqs
> Date: Fri Dec 30 10:58:14 2011
> New Revision: 228990
> URL: http://svn.freebsd.org/changeset/base/228990
>
> Log:
>  Spelling fixes for usr.sbin/
>
> Modified: head/usr.sbin/bluetooth/sdpd/server.c
> ==============================================================================
> --- head/usr.sbin/bluetooth/sdpd/server.c       Fri Dec 30 10:45:00 2011        (r228989)
> +++ head/usr.sbin/bluetooth/sdpd/server.c       Fri Dec 30 10:58:14 2011        (r228990)
> @@ -334,7 +334,7 @@ server_accept_client(server_p srv, int32
>                 * The minimum L2CAP MTU is 43 bytes. That means we need
>                 * 65536 / 43 = ~1524 chunks to transfer maximum packet
>                 * size with minimum MTU. The "rsp_cs" field in fd_idx_t
> -                * is 11 bit wide that gives us upto 2048 chunks.
> +                * is 11 bit wide that gives us up to 2048 chunks.

Should be "11 bits", no?

>                 */
>
>                if (omtu < NG_L2CAP_MTU_MINIMUM) {
>
> Modified: head/usr.sbin/bsnmpd/modules/snmp_wlan/BEGEMOT-WIRELESS-MIB.txt
> ==============================================================================
> --- head/usr.sbin/bsnmpd/modules/snmp_wlan/BEGEMOT-WIRELESS-MIB.txt     Fri Dec 30 10:45:00 2011        (r228989)
> +++ head/usr.sbin/bsnmpd/modules/snmp_wlan/BEGEMOT-WIRELESS-MIB.txt     Fri Dec 30 10:58:14 2011        (r228990)
> @@ -82,8 +82,8 @@ WlanMgmtReasonCode ::= TEXTUAL-CONVENTIO
>                    associationLeave(8),
>                    associationNotAuthenticated(9),
>  -- XXX: TODO - FIXME
> -                   dissasocPwrcapBad(10),
> -                   dissasocSuperchanBad(11),
> +                   disassocPwrcapBad(10),
> +                   disassocSuperchanBad(11),

This file looks like it might be intended to be machine-readable -- I
would worry about changing it without test/review.
Perhaps this spelling "error" is even the reason for the XXX comment above.

>                    ieInvalid(13),
>                    micFailure(14),
>                    fourWayHandshakeTimeout(15),
> @@ -579,10 +579,10 @@ wlanIfaceCountryCode OBJECT-TYPE
>        interface is operating include all environments in the specified
>        country.
>
> -       2. an ASCII 'O' character, if the country's regulastions are for
> +       2. an ASCII 'O' character, if the country's regulations are for
>        Outdoor environment only.
>
> -       3. an ASCII 'I' character, if the country's regulastions are for
> +       3. an ASCII 'I' character, if the country's regulations are for
>        Indoor environment only."
>     ::= { wlanIfaceConfigEntry 2 }
>
> @@ -634,7 +634,7 @@ wlanIfaceFastFrames OBJECT-TYPE
>     DESCRIPTION
>        "The value of this object controls whether use of Atheros Fast
>        Frames is enabled when when communicating with another Fast
> -       Frames-capable station. The value is only meaningfull for
> +       Frames-capable station. The value is only meaningful for
>        interfaces that support Atheros Fast Frames."
>     ::= { wlanIfaceConfigEntry 7 }
>
> @@ -645,7 +645,7 @@ wlanIfaceDturbo OBJECT-TYPE
>     DESCRIPTION
>        "The value of this object controls whether use of Atheros Dynamic
>        Turbo mode is enabled when when communicating with another Dynamic
> -       Turbo-capable station. The value is only meaningfull for interfaces
> +       Turbo-capable station. The value is only meaningful for interfaces
>        that support Atheros Dynamic Turbo mode."
>     ::= { wlanIfaceConfigEntry 8 }
>
> @@ -731,7 +731,7 @@ wlanIfaceBeaconMissedThreshold OBJECT-TY
>     MAX-ACCESS read-write
>     STATUS     current
>     DESCRIPTION
> -       "The value of this object specifies the number of consequtive missed
> +       "The value of this object specifies the number of consecutive missed
>        beacons before an interface operating in station mode will attempt
>        to search for a new access point."
>     DEFVAL     { 7 }
> @@ -788,7 +788,7 @@ wlanIfaceDynamicWds OBJECT-TYPE
>     STATUS     current
>     DESCRIPTION
>        "The value of this object specifies whether Dynamic WDS (DWDS)
> -       support is enabled. The value is only meaningfull for interfaces
> +       support is enabled. The value is only meaningful for interfaces
>        that support Dynamic WDS."
>     ::= { wlanIfaceConfigEntry 21 }
>
> @@ -798,7 +798,7 @@ wlanIfacePowerSave OBJECT-TYPE
>     STATUS     current
>     DESCRIPTION
>        "The value of this object specifies whether powersave operation
> -       is enabled. The value is only meaningfull for interfaces that
> +       is enabled. The value is only meaningful for interfaces that
>        support powersave operation."
>     ::= { wlanIfaceConfigEntry 22 }
>
> @@ -809,7 +809,7 @@ wlanIfaceApBridge OBJECT-TYPE
>     DESCRIPTION
>        "The value of this object specifies whether packets between
>        wireless clients will be passed directly by an interface
> -       operating in host ap mode. Disabling it may be usefull in
> +       operating in host ap mode. Disabling it may be useful in
>        situations when traffic between wireless clients needs to be
>        processed with packet filtering."
>     DEFVAL     { true }
> @@ -1308,7 +1308,7 @@ wlanIfaceChannelFrequency OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The channel frequency setting in Mhz."
> +       "The channel frequency setting in MHz."
>     ::= { wlanIfaceChannelEntry 5 }
>
>  wlanIfaceChannelMaxRegPower OBJECT-TYPE
> @@ -2741,7 +2741,7 @@ wlanStatsDwdsMcastDiscard OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The number of multicast over DWDS frames discared by this interface."
> +       "The number of multicast over DWDS frames discarded by this interface."
>     ::= { wlanIfaceStatisticsEntry 98 }
>
>  wlanStatsHTAssocRejectNoHT OBJECT-TYPE
> @@ -2759,7 +2759,7 @@ wlanStatsHTAssocDowngrade OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The number of times HT was dissallowed for an association on
> +       "The number of times HT was disallowed for an association on
>        this interface due to WEP or TKIP requested."
>     ::= { wlanIfaceStatisticsEntry 100 }
>
> @@ -2769,7 +2769,7 @@ wlanStatsHTAssocRateMismatch OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The number of times rate mismatch occured furing HT rate set
> +       "The number of times rate mismatch occurred during HT rate set
>        handling on this interface."
>     ::= { wlanIfaceStatisticsEntry 101 }
>
> @@ -2787,7 +2787,7 @@ wlanStatsAMPDUMoved OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The number of time A-MPDU MSDU moved window occured for this
> +       "The number of time A-MPDU MSDU moved window occurred for this
>        interface."
>     ::= { wlanIfaceStatisticsEntry 103 }
>
> @@ -2807,7 +2807,7 @@ wlanStatsADDBANoRequest OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The number of received ADDBA responces frames that were discarded
> +       "The number of received ADDBA responses frames that were discarded
>        by this interface due to no pending ADDBA."
>     ::= { wlanIfaceStatisticsEntry 105 }
>
> @@ -2817,7 +2817,7 @@ wlanStatsADDBABadToken OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The number of received ADDBA responce frames that were discarded
> +       "The number of received ADDBA response frames that were discarded
>        by this interface since ADDBA response caused dialogtoken mismatch."
>     ::= { wlanIfaceStatisticsEntry 106 }
>
> @@ -2827,7 +2827,7 @@ wlanStatsADDBABadPolicy OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The number of received ADDBA responce frames that were discarded
> +       "The number of received ADDBA response frames that were discarded
>        by this interface since ADDBA response caused policy mismatch."
>     ::= { wlanIfaceStatisticsEntry 107 }
>
> @@ -2877,7 +2877,7 @@ wlanLastDissasocReason OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The last received dissasociate reason on this interface."
> +       "The last received disassociate reason on this interface."
>     ::= { wlanIfaceStatisticsEntry 113 }
>
>  wlanLastAuthFailReason OBJECT-TYPE
> @@ -2942,7 +2942,7 @@ wlanStatsAMPDURexmtFailed OBJECT-TYPE
>     MAX-ACCESS read-only
>     STATUS     current
>     DESCRIPTION
> -       "The number of A-MPDU frames for which retransmition failed on
> +       "The number of A-MPDU frames for which retransmission failed on
>        this interface."
>     ::= { wlanIfaceStatisticsEntry 120 }
>
> @@ -3696,7 +3696,7 @@ wlanMeshDroppedMisaligned OBJECT-TYPE
>     STATUS     current
>     DESCRIPTION
>        "The number of frames that were dropped by this interface due to
> -       bad alighment."
> +       bad alignment."
>     ::= { wlanMeshStatsEntry 11 }
>
>  -- ---------------------------------------------------------- --
>
> Modified: head/usr.sbin/bsnmpd/modules/snmp_wlan/wlan_tree.def
> ==============================================================================
> --- head/usr.sbin/bsnmpd/modules/snmp_wlan/wlan_tree.def        Fri Dec 30 10:45:00 2011        (r228989)
> +++ head/usr.sbin/bsnmpd/modules/snmp_wlan/wlan_tree.def        Fri Dec 30 10:58:14 2011        (r228990)
> @@ -75,8 +75,8 @@ typedef WlanMgmtReasonCode ENUM (
>        7 notAssociated
>        8 associationLeave
>        9 associationNotAuthenticated
> -       10 dissasocPwrcapBad
> -       11 dissasocSuperchanBad
> +       10 disassocPwrcapBad
> +       11 disassocSuperchanBad

Hmm, but the same mis-spellings are also changed here (and presumably
elsewhere), so maybe it is less risky.

>        13 ieInvalid
>        14 micFailure
>        15 fourWayHandshakeTimeout
>
> Modified: head/usr.sbin/cron/doc/CHANGES
> ==============================================================================
> --- head/usr.sbin/cron/doc/CHANGES      Fri Dec 30 10:45:00 2011        (r228989)
> +++ head/usr.sbin/cron/doc/CHANGES      Fri Dec 30 10:58:14 2011        (r228990)
> @@ -1,3 +1,6 @@
> +$FreeBSD$
> +--------
> +
>  Vixie Cron             Changes from V2 to V3
>  Paul Vixie
>  29-Dec-1993
> @@ -20,7 +23,7 @@ be reread whenever it changes.
>
>  I also added a "-e" option to crontab(1).  Nine people also sent me diffs
>  to add this option, but I had already implemented it on my own.  I actually
> -released an interrim version (V2.2, I think) for limited testing, and got a
> +released an interim version (V2.2, I think) for limited testing, and got a

Should we really be in the business of modifying Vixie's changelog?

>  chance to fix a bad security bug in the "-e" option thanks to XXX.
>
>  The daemon used to be extraordinarily sloppy in its use of file descriptors.
> @@ -57,7 +60,7 @@ which explains why a lot of other people
>  syslog even when they configured it that way :-).  Steve Simmons told me
>  first, though, so he gets the point.
>
> -An interrim version of the daemon tried to "stat" every file before
> +An interim version of the daemon tried to "stat" every file before
>  executing it; this turned out to be a horribly bad idea since finding the
>  name of a file from a shell command is a hard job (that's why we have
>  shells, right?)  I removed this bogus code.  Dave Burgess gets the point.
>
> Modified: head/usr.sbin/newsyslog/newsyslog.c
> ==============================================================================
> --- head/usr.sbin/newsyslog/newsyslog.c Fri Dec 30 10:45:00 2011        (r228989)
> +++ head/usr.sbin/newsyslog/newsyslog.c Fri Dec 30 10:58:14 2011        (r228990)
> @@ -1597,7 +1597,7 @@ delete_oldest_timelog(const struct conf_
>  }
>
>  /*
> - * Generate a log filename, when using clasic filenames.
> + * Generate a log filename, when using classic filenames.
>  */
>  static void
>  gen_clasiclog_fname(char *fname, size_t fname_sz, const char *archive_dir,
> @@ -1612,7 +1612,7 @@ gen_clasiclog_fname(char *fname, size_t
>  }
>
>  /*
> - * Delete a rotated logfiles, when using clasic filenames.
> + * Delete a rotated logfiles, when using classic filenames.

"a logfiles" is inconsistent.  Without looking up the implementation,
I'm going to guess that "a rotated logfile" is correct.

>  */
>  static void
>  delete_clasiclog(const char *archive_dir, const char *namepart, int numlog_c)
>
> Modified: head/usr.sbin/ntp/doc/ntp.conf.5
> ==============================================================================
> --- head/usr.sbin/ntp/doc/ntp.conf.5    Fri Dec 30 10:45:00 2011        (r228989)
> +++ head/usr.sbin/ntp/doc/ntp.conf.5    Fri Dec 30 10:58:14 2011        (r228990)
> @@ -783,7 +783,7 @@ The remaining files are necessary only f
>  Autokey protocol.
>  .Pp
>  Certificates imported from OpenSSL or public certificate
> -authorities have certian limitations.
>
> *** DIFF OUTPUT TRUNCATED AT 1000 LINES ***

Hmm, that's unfortunate.
Pulling out a svn client, it looks like:
usr.sbin/pkg_install/lib/plist.c changes a misspelled form to the
still-misspelled "occurrance" (not occurrence)

Thanks for doing this cleanup along with the encoding cleanup!

-Ben Kaduk


More information about the svn-src-all mailing list